Modernize kb layouts#410
Merged
Merged
Conversation
11 tasks
There was a problem hiding this comment.
Copilot reviewed 18 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (5)
- debian/cinnamon-settings-daemon.install: Language not supported
- debian/control: Language not supported
- debian/rules: Language not supported
- meson.build: Language not supported
- plugins/keyboard/meson.build: Language not supported
Comments suppressed due to low confidence (4)
plugins/settings-remap/csd-settings-remap-manager.c:63
- Verify that the removal of the a11y and input-sources schema mappings is intentional and that any dependent functionality is updated accordingly.
- { "org.gnome.desktop.a11y", "org.cinnamon.desktop.a11y.keyboard" },
plugins/keyboard/main.c:12
- Confirm that removing the forced X11 backend definition does not negatively impact environments that may rely on it.
-// This plugin must run under x11/xwayland
plugins/keyboard/csd-keyboard-manager.h:38
- The include guard has been changed to __GSD_KEYBOARD_MANAGER_H which does not match the file name; please update it to __CSD_KEYBOARD_MANAGER_H if that was intended.
+#endif /* __GSD_KEYBOARD_MANAGER_H */
plugins/a11y-settings/csd-a11y-settings-manager.c:189
- Ensure that the removal of the binding for 'screen-keyboard-enabled' is intentional and that its functionality is either no longer required or handled elsewhere.
- bind_keys (manager, CINNAMON_A11Y_APP_SCHEMA, "screen-keyboard-enabled", GNOME_A11Y_APP_SCHEMA, "screen-keyboard-enabled");
802fa0c to
79219ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: linuxmint/cinnamon#12758